Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check CountSubKeys nil #15059

Merged
merged 5 commits into from
Feb 19, 2023
Merged

fix: check CountSubKeys nil #15059

merged 5 commits into from
Feb 19, 2023

Conversation

JulianToledano
Copy link
Contributor

Description

Closes:
#6889
#15056


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JulianToledano JulianToledano requested a review from a team as a code owner February 17, 2023 12:26
@github-prbot github-prbot requested a review from a team February 17, 2023 12:26
@github-prbot github-prbot requested review from julienrbrt and atheeshp and removed request for a team February 17, 2023 12:26
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a CL entry in under Bug Fix 👍

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 17, 2023
@mergify mergify bot merged commit 9553bf1 into cosmos:main Feb 19, 2023
@JulianToledano JulianToledano deleted the fix/countsubkeys branch February 20, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
4 participants