-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(adr): Change Textual SignDoc to struct #15282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ebfca1
to
1f7f358
Compare
amaury1093
commented
Mar 7, 2023
@@ -1,19 +1,19 @@ | |||
[ | |||
{ | |||
"screens": [], | |||
"encoding": "80" | |||
"encoding": "a10180" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CBOR encodings now have a101
prepended. Looking at the RFC Appendix B, this makes sense:
| 0xa0..0xb7 | map (0x00..0x17 pairs of data items follow) |
a1
: map with 1 item01
: key of first item
kocubinski
approved these changes
Mar 7, 2023
alexanderbez
approved these changes
Mar 7, 2023
julienrbrt
approved these changes
Mar 7, 2023
I'll enable auto-merge once it's tested with Zondax's new ledger app |
39 tasks
Tested, merging. |
9 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When discussing today about Spec updates, we came up with the argument that structs are more backwards-compatible than arrays. Propose to switch the sign doc to a struct containing one field (the old array).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change