Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky group genesis sim #15447

Merged
merged 4 commits into from
Mar 20, 2023
Merged

fix: flaky group genesis sim #15447

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ecb521
fix: flaky gov genesis sim
robert-zaremba Mar 17, 2023
c0203df
Merge branch 'main' into robert/flaky-gov-sim
tac0turtle Mar 19, 2023
a88ef98
Merge branch 'main' into robert/flaky-gov-sim
tac0turtle Mar 20, 2023
d4581ea
Merge branch 'main' into robert/flaky-gov-sim
julienrbrt Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions x/group/simulation/genesis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ const (
GroupVote = "group-vote"
)

func checkAccExists(acc sdk.AccAddress, g []*group.GroupMember, lastIndex int) bool {
s := acc.String()
for i := 0; i < lastIndex; i++ {
if g[i].Member.Address == s {
return true
}
}
return false
}

func getGroups(r *rand.Rand, accounts []simtypes.Account) []*group.GroupInfo {
groups := make([]*group.GroupInfo, 3)
for i := 0; i < 3; i++ {
Expand All @@ -40,6 +50,9 @@ func getGroupMembers(r *rand.Rand, accounts []simtypes.Account) []*group.GroupMe
groupMembers := make([]*group.GroupMember, 3)
for i := 0; i < 3; i++ {
acc, _ := simtypes.RandomAcc(r, accounts)
for checkAccExists(acc.Address, groupMembers, i) {
acc, _ = simtypes.RandomAcc(r, accounts)
}
groupMembers[i] = &group.GroupMember{
GroupId: uint64(i + 1),
Member: &group.Member{
Expand Down Expand Up @@ -147,6 +160,11 @@ func getVoteOption(index int) group.VoteOption {

// RandomizedGenState generates a random GenesisState for the group module.
func RandomizedGenState(simState *module.SimulationState) {
// The test requires we have at least 3 accounts.
if len(simState.Accounts) < 3 {
return
}

// groups
var groups []*group.GroupInfo
simState.AppParams.GetOrGenerate(
Expand Down