Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth,vesting): move ValidateBasic logic to msgServer #15786

Merged
merged 16 commits into from
Apr 12, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #15648


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner April 11, 2023 13:30
@julienrbrt julienrbrt mentioned this pull request Apr 11, 2023
19 tasks
@github-prbot github-prbot requested a review from a team April 11, 2023 13:30
@github-prbot github-prbot requested review from JeancarloBarrios and testinginprod and removed request for a team April 11, 2023 13:30
@julienrbrt
Copy link
Member Author

2a1e3c8 implements as well the comments from a previous PR and makes all modules consistent: #15760 (comment)

@github-actions github-actions bot added the C:x/distribution distribution module related label Apr 11, 2023
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is verified and tested in the message server tests

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 12, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) April 12, 2023 12:58
@julienrbrt julienrbrt merged commit e4dbf1b into main Apr 12, 2023
47 of 48 checks passed
@julienrbrt julienrbrt deleted the julien/validate-auth-vesting branch April 12, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth C:x/authz C:x/crisis C:x/distribution distribution module related C:x/gov C:x/mint C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants