refactor(slashing): move ValidateBasic logic to msgServer
#15793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
aaronc and
likhita-809
and removed request for
a team
julienrbrt
commented
Apr 11, 2023
| @@ -50,10 +50,6 @@ func (k Keeper) GetParams(ctx sdk.Context) (params types.Params) { | |||
|
|
|||
| // SetParams sets the x/slashing module parameters. | |||
| func (k Keeper) SetParams(ctx sdk.Context, params types.Params) error { | |||
| if err := params.Validate(); err != nil { | |||
There was a problem hiding this comment.
The change for this is mentioned in a changelog from this PR: #15786.
This makes consistent all SetParams methods, some were validating params whereas some did not.
Now we always validate in the msg server and only there.
There was a problem hiding this comment.
should we make setParams internal to avoid others accidentally calling it without calling validation or leave a contact comment saying the caller should call validate
There was a problem hiding this comment.
You may have a module that updates other module params by calling the keeper, so making it private is a no-go imho.
We could add a comment, indeed.
julienrbrt
added a commit
that referenced
this pull request
Apr 11, 2023
tac0turtle
reviewed
Apr 11, 2023
Co-authored-by: Marko <marbar3778@yahoo.com>
tac0turtle
approved these changes
Apr 11, 2023
julienrbrt
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #15648
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change