Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed the data type for FeePayer and FeeGranter #16272

Merged
merged 25 commits into from
Jul 11, 2023
Merged

fix: changed the data type for FeePayer and FeeGranter #16272

merged 25 commits into from
Jul 11, 2023

Conversation

vishal-kanna
Copy link
Contributor

@vishal-kanna vishal-kanna commented May 24, 2023 •
edited
Loading

Description

Closes: #16183

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@vishal-kanna vishal-kanna requested a review from a team as a code owner May 24, 2023 11:58
@github-prbot github-prbot requested review from a team, JeancarloBarrios and likhita-809 and removed request for a team May 24, 2023 11:58
@vishal-kanna vishal-kanna changed the title changed the data type for FeePayer and FeeGranter feat:changed the data type for FeePayer and FeeGranter May 24, 2023
@vishal-kanna vishal-kanna changed the title feat:changed the data type for FeePayer and FeeGranter fix: changed the data type for FeePayer and FeeGranter May 24, 2023
@aaronc
Copy link
Member

aaronc commented May 24, 2023

Thanks for your contribution @vishal-kanna! This issue is specifically related to #15284, so it was intended to be addressed after that is merged. I don't think it makes as much sense before this. Would you be interested in retackling this after #15284 gets merged?

@vishal-kanna
Copy link
Contributor Author

@aaronc okay i'll tackle this issue, once the issue #15284 gets merged.

@atheeshp
Copy link
Contributor

atheeshp commented May 30, 2023 •
edited
Loading

Hey @vishal-kanna, seems like the dependant PR got merged, you can resume your work.

@atheeshp
Copy link
Contributor

atheeshp commented Jun 5, 2023

Can you also check the failing tests & and add a changelog entry?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jul 6, 2023
@alexanderbez
Copy link
Contributor

Looks like we'll need someone to take over this.

@github-actions github-actions bot removed the Stale label Jul 7, 2023
julienrbrt
julienrbrt requested changes Jul 7, 2023
View reviewed changes
x/auth/tx/direct_aux.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
x/auth/tx/direct_aux.go Outdated Show resolved Hide resolved
likhita-809
likhita-809 reviewed Jul 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
x/auth/ante/fee.go Outdated Show resolved Hide resolved
x/auth/ante/fee.go Outdated Show resolved Hide resolved
x/auth/ante/fee.go Outdated Show resolved Hide resolved
x/auth/tx/builder.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt reviewed Jul 7, 2023
View reviewed changes
x/auth/tx/direct_aux.go Outdated Show resolved Hide resolved
likhita-809
likhita-809 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit. Otherwise lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
likhita-809
likhita-809 reviewed Jul 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

x/auth/tx/direct_aux.go Outdated
feePayer := protoTx.FeePayer()
payer := protoTx.FeePayer()

feepayer := sdk.AccAddress(payer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for simplicity, we could just do sdk.AccAddress(payer).String() below and revert the variable change above.

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 7, 2023
likhita-809
likhita-809 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atheeshp atheeshp enabled auto-merge July 11, 2023 10:05
atheeshp
atheeshp reviewed Jul 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled July 11, 2023 10:11

Head branch was pushed to by a user without write access

@atheeshp atheeshp added this pull request to the merge queue Jul 11, 2023
Merged via the queue into cosmos:main with commit 8003261 Jul 11, 2023
44 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
@vishal-kanna @mergify
fix: changed the data type for FeePayer and FeeGranter (#16272)
ebd3a4a 
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
(cherry picked from commit 8003261)
@mergify mergify bot mentioned this pull request Jul 11, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Jul 11, 2023
@mergify @vishal-kanna
fix: changed the data type for FeePayer and FeeGranter (backport #16272…
5ca5039 
…) (#16920)

Co-authored-by: Vishal Potpelliwar <71565171+vishal-kanna@users.noreply.github.com>
@julienrbrt julienrbrt mentioned this pull request Jul 17, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@atheeshp atheeshp atheeshp left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@likhita-809 likhita-809 likhita-809 approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@kocubinski kocubinski Awaiting requested review from kocubinski

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FeeTx.FeePayer and FeeTx.FeeGranter should be of the same type
6 participants
@vishal-kanna @aaronc @atheeshp @alexanderbez @julienrbrt @likhita-809