Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changelog & upgrading documentation for ABCI++ #16315

Merged
merged 20 commits into from
Jun 9, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #12272

this adds a changelog for changes from integrating comet 0.38


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt
Copy link
Member

Slightly unrelated but posting this here, so we can add it in the changelog as well: #16043 (comment) (and then I can close a tab)

UPGRADING.md Outdated Show resolved Hide resolved
@alexanderbez alexanderbez changed the title chore: changelog for abci++ chore: changelog/upgrading documentation for ABCI++ Jun 8, 2023
@alexanderbez alexanderbez changed the title chore: changelog/upgrading documentation for ABCI++ chore: changelog & upgrading documentation for ABCI++ Jun 8, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 8, 2023
@tac0turtle tac0turtle marked this pull request as ready for review June 8, 2023 20:15
@tac0turtle tac0turtle requested a review from a team as a code owner June 8, 2023 20:15
@github-prbot github-prbot requested review from a team, aaronc and facundomedica and removed request for a team June 8, 2023 20:15
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits (the link and the title). We will still need docs for updating the flow.
We still require docs to update the baseapp core concepts and describe finalize block, verify vote extensions, etc..
It will be great as well to add a disclaimer here: https://docs.cosmos.network/v0.50/building-modules/beginblock-endblock about what means BeginBlock and EndBlock now.

docs/docs/building-apps/01-app-go-v2.md Outdated Show resolved Hide resolved
docs/docs/building-apps/04-vote-extensions.md Outdated Show resolved Hide resolved
docs/docs/building-apps/04-vote-extensions.md Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I guess the other updates I suggested could be done in another issue as part of QA: #16315 (review)

@tac0turtle
Copy link
Member Author

ACK. I guess the other updates I suggested could be done in another issue as part of QA: #16315 (review)

#16481

i will pick this up

@tac0turtle tac0turtle enabled auto-merge June 9, 2023 11:04
@tac0turtle tac0turtle added this pull request to the merge queue Jun 9, 2023
Merged via the queue into main with commit 9769e24 Jun 9, 2023
42 of 43 checks passed
@tac0turtle tac0turtle deleted the marko/abci++_changelog branch June 9, 2023 11:09
mergify bot pushed a commit that referenced this pull request Jun 9, 2023
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 9769e24)
tac0turtle added a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC: ABCI++
3 participants