Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CLI commands: 1) simulate a transaction, 2) query block results #16887

Merged
merged 8 commits into from
Jul 12, 2023

Conversation

larry0x
Copy link
Contributor

@larry0x larry0x commented Jul 7, 2023

Description

Closes: #16886

Adds the two following CLI commands:

simd tx simulate /path/to/unsigned-tx.json
simd query block-results [height]

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@larry0x larry0x requested a review from a team as a code owner July 7, 2023 21:34
@github-prbot github-prbot requested review from a team, alexanderbez and atheeshp and removed request for a team July 7, 2023 21:34
@larry0x larry0x changed the title feat: Add a CLI command to simulate a transaction feat: Add CLI commands: 1) simulate a transaction, 2) query block results Jul 7, 2023
@julienrbrt
Copy link
Member

Can we get a changelog entry under Unreleased Feature?

@larry0x
Copy link
Contributor Author

larry0x commented Jul 8, 2023

Can we get a changelog entry under Unreleased Feature?

Updated changelog

@larry0x
Copy link
Contributor Author

larry0x commented Jul 8, 2023

I think the question is whether the query block-results command is a satisfactory implementation. We serialize the response as json instead of using clientCtx.PrintProto which is a bit dirty. Looking for advice

@facundomedica facundomedica self-assigned this Jul 10, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, the json serialisation looks fine. With other types we end up creating our own type wrapper (

func NewResponseResultBlock(res *coretypes.ResultBlock, timestamp string) *cmtproto.Block {
) but i think this is overkill. It provides the ability to add it to grpc

Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, looks good,

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release and removed backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Jul 12, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jul 12, 2023
Merged via the queue into cosmos:main with commit ca74dcc Jul 12, 2023
38 of 45 checks passed
mergify bot pushed a commit that referenced this pull request Jul 12, 2023
…ults (#16887)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
(cherry picked from commit ca74dcc)

# Conflicts:
#	CHANGELOG.md
julienrbrt added a commit that referenced this pull request Jul 12, 2023
…ults (backport #16887) (#16962)

Co-authored-by: larry <26318510+larry0x@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add two CLI query commands: block-results and simulate
5 participants