Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry-pick some inj changes #17109

Merged
merged 4 commits into from
Jul 24, 2023
Merged

chore: cherry-pick some inj changes #17109

merged 4 commits into from
Jul 24, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 24, 2023 •
edited
Loading

Description

Cherry-pick some small cosmos sdk changes fom Injective fork: v0.47.3...InjectiveLabs:cosmos-sdk:v0.47.3-inj-1
These should not be backported to v0.47 but still good for v0.50.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 24, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner July 24, 2023 12:20
@github-prbot github-prbot requested a review from a team July 24, 2023 12:21
@github-prbot github-prbot requested review from alexanderbez and atheeshp and removed request for a team July 24, 2023 12:21
@julienrbrt julienrbrt added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 5442197 Jul 24, 2023
50 of 51 checks passed
@julienrbrt julienrbrt deleted the julien/cherry-pick-inj branch July 24, 2023 13:10
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
@julienrbrt @mergify
chore: cherry-pick some inj changes (#17109)
8d64de1 
(cherry picked from commit 5442197)

# Conflicts:
#	CHANGELOG.md
#	math/CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 24, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 24, 2023
@mergify @julienrbrt
chore: cherry-pick some inj changes (backport #17109) (#17110)
983c9f7 
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:Keys Keybase, KMS and HSMs C:x/gov C:x/group C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienrbrt @tac0turtle