Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: use context.Context in genesis api #17885

Merged
merged 5 commits into from
Sep 26, 2023
Merged

refactor!: use context.Context in genesis api #17885

merged 5 commits into from
Sep 26, 2023

Conversation

tac0turtle
Copy link
Member

Description

opening this as a proposal on removing sdk.Context from usage in tmport and export genesis

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review September 26, 2023 15:00
@tac0turtle tac0turtle requested a review from a team as a code owner September 26, 2023 15:00
@github-prbot github-prbot requested review from a team, kocubinski and testinginprod and removed request for a team September 26, 2023 15:01
@julienrbrt julienrbrt changed the title chore: use context.Context in genesis api refactor!: use context.Context in genesis api Sep 26, 2023
julienrbrt
julienrbrt approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! One nit.

types/module/module.go
@@ -184,15 +184,15 @@ func (bm BasicManager) AddQueryCommands(rootQueryCmd *cobra.Command) {
// HasGenesis is the extension interface for stateful genesis methods.
type HasGenesis interface {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a mention in UPGRADING.md > Unreleased > Modules > all ?

testinginprod
testinginprod approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; are we planning to remove codec.JSONCodec which leaks the SDK dep?

@tac0turtle
Copy link
Member Author

LGTM; are we planning to remove codec.JSONCodec which leaks the SDK dep?

yup yup ill work on removing them

@julienrbrt
Copy link
Member

Given that codec.JSONCodec is an interface, should we not have it in core/codec instead ?

@tac0turtle
Copy link
Member Author

Given that codec.JSONCodec is an interface, should we not have it in core/codec instead ?

want to avoid moving to moving, unless we are fine putting interfaces in there in the short term

@tac0turtle tac0turtle added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 9d07b8c Sep 26, 2023
51 of 52 checks passed
@tac0turtle tac0turtle deleted the marko/removesdkContext branch September 26, 2023 16:05
@julienrbrt
Copy link
Member

julienrbrt commented Sep 26, 2023 •
edited
Loading

Given that codec.JSONCodec is an interface, should we not have it in core/codec instead ?

want to avoid moving to moving, unless we are fine putting interfaces in there in the short term

Core shouldn't be short term, so best not to move it if it's not going to stay.
But I am curious why it couldn't stay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@testinginprod testinginprod testinginprod approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees

@julienrbrt julienrbrt

@testinginprod testinginprod

Labels
C:x/auth C:x/authz C:x/bank C:x/circuit C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/slashing C:x/staking C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tac0turtle @julienrbrt @testinginprod