Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): in-place testnet creator (backport #19280) #19406

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 12, 2024

This is an automatic backport of pull request #19280 done by Mergify.
Cherry-pick of 89df28c has failed:

On branch mergify/bp/release/v0.47.x/pr-19280
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit 89df28ceb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   server/util.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   baseapp/options.go
	both modified:   server/start.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 89df28c)

# Conflicts:
#	CHANGELOG.md
#	baseapp/options.go
#	server/start.go
@mergify mergify bot requested a review from a team as a code owner February 12, 2024 10:57
@mergify mergify bot added the conflicts label Feb 12, 2024
@julienrbrt julienrbrt marked this pull request as draft February 12, 2024 10:59
@julienrbrt
Copy link
Member

Before merging and fixing this, we need to decide if we make an exception to our release policy (no feature or improvements in bug fix only versions): ref #19280 (comment)

@@ -625,4 +660,431 @@
}

return WaitForQuitSignals()
=======
return callbackFn()

Check warning

Code scanning / CodeQL

Unreachable statement Warning

This statement is unreachable.
Comment on lines +730 to +732
if opts.DBOpener == nil {
opts.DBOpener = OpenDB
}

Check warning

Code scanning / CodeQL

Unreachable statement Warning

This statement is unreachable.
@julienrbrt julienrbrt closed this Feb 15, 2024
@mergify mergify bot deleted the mergify/bp/release/v0.47.x/pr-19280 branch February 15, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants