fix(depinject): Authtx was not accepting custom signers

[itsdevbear]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features
  • Enhanced transaction signing capabilities with custom signers support for more flexible and secure transaction processing.

[coderabbitai]

Walkthrough

Walkthrough

This update introduces a new mechanism to customize signer retrieval in the authentication module by leveraging the protoreflect package. It adds a CustomGetSigners field to ModuleInputs, allowing for dynamic signers processing. This field is populated in the ProvideModule function, and its presence influences the enabled signing modes, especially when MetadataBankKeeper is involved. This enhancement facilitates more flexible and efficient signer management within the module.

Changes

File	Change Summary
x/auth/tx/config/depinject.go	- Imported protoreflect for enhanced reflection capabilities. - Added and initialized CustomGetSigners in ModuleInputs. - Processed CustomGetSigners for dynamic signer retrieval. - Adjusted enabled sign modes based on MetadataBankKeeper.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between aa9ff3d and 66d985c.

Files selected for processing (1)

• x/auth/tx/config/depinject.go (3 hunks)

Additional comments: 4

x/auth/tx/config/depinject.go (4)

• 11-11: The addition of the protoreflect import from google.golang.org/protobuf/reflect/protoreflect is necessary for handling protocol buffer message reflection, which is likely crucial for the implementation of custom signers. This change aligns with the PR's objective to enhance the SDK's flexibility in cryptographic operations.
• 81-81: Initializing the CustomGetSigners map within the ProvideModule function is a crucial step for setting up the infrastructure to support custom signers. This initialization ensures that the map is ready to be populated with custom signer functions, facilitating the SDK's ability to handle transactions signed with custom algorithms. This change is well-implemented and follows best practices for map initialization in Go.
• 86-90: The processing of CustomGetSigners to populate SigningOptions is effectively implemented. By iterating over the CustomGetSigners slice and assigning each custom signer function to the corresponding message type in the map, this code segment ensures that custom signing mechanisms are correctly integrated into the SDK's transaction handling process. This approach is both efficient and clear, contributing to the SDK's extensibility.
• 91-91: The conditional logic to update enabled sign modes based on the presence of MetadataBankKeeper is a thoughtful addition. By enabling SIGN_MODE_TEXTUAL only when MetadataBankKeeper is available, this change introduces a nuanced approach to managing sign modes, potentially offering more tailored signing configurations. This adjustment is in line with the PR's objectives to enhance the SDK's flexibility and developer experience.

[coderabbitai]

The introduction of the CustomGetSigners field to ModuleInputs is a key change that enables the support for custom signers. This addition is essential for the SDK to accommodate a broader range of signing algorithms, improving its adaptability for various projects. It's important to ensure that this field is properly documented to guide developers on how to utilize this new functionality effectively.

Consider adding comprehensive documentation for the CustomGetSigners field to explain its purpose, usage, and how developers can implement custom signers using this new feature.

[julienrbrt]

Good find! Can we get a changelog?