-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #20218
base: server_modular
Are you sure you want to change the base?
Add CI #20218
Conversation
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
1a976b7
to
3b04c49
Compare
simdv2.sh
Outdated
$SIMD genesis collect-gentxs | ||
|
||
cd v2/simdv2/ | ||
go run main.go start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not doing a lot. Also bash can be very annoying. I would be happy to help migrating this to system tests if you can outline the requirements or test assumptions.
When I was testing with app v2, I had some problems on chain upgrade but CI is prepared: https://github.com/cosmos/cosmos-sdk/blob/main/.github/workflows/test.yml#L190
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need simapp v2s init and genesis code paths tested so that we don't get regressions in this branch. roughly
$SIMD init test-node --chain-id test-chain
$SIMD genesis add-genesis-account "$VALIDATOR_ADDRESS" 1000000000stake
$SIMD genesis gentx test_validator 1000000000stake --keyring-backend test
$SIMD genesis collect-gentxs
# edit config yaml to halt after 5 blocks
$SIMD start
# assert exit status 0
simapp/v2/simdv2/cmd/commands.go
Outdated
@@ -76,7 +76,7 @@ func initRootCmd( | |||
// snapshot.Cmd(newApp), | |||
) | |||
|
|||
server.AddCommands(rootCmd, log.NewNopLogger(), tempDir(), nil) // TODO: How to cast from AppModule to ServerModule | |||
// server.AddCommands(rootCmd, log.NewNopLogger(), tempDir(), nil) // TODO: How to cast from AppModule to ServerModule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a solution, there are no server commands added to the root cmd here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readd serverv2
scripts/simdv2.sh
Outdated
$SIMD genesis collect-gentxs | ||
|
||
cd v2/simdv2/ | ||
go run main.go start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add a wait command for block n here, also it should be commented out until it works.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...