Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/authz,x/feegrant): provide updated keeper in depinject #20590

Merged
merged 4 commits into from
Jun 7, 2024
Merged

refactor(x/authz,x/feegrant): provide updated keeper in depinject #20590

merged 4 commits into from
Jun 7, 2024

Conversation

julienrbrt
Copy link
Member

Description

Closes: #20589

Better UX so that the keeper provided by depinject in the app as well contain the bank keeper.
We cannot make the UX better than that without have a breaking change.
Users that want to have the bank keeper in the authz and feegrant modules and aren't using depinject need to call this themselves (however, shouldn't be needed as the check is in the message handling flow -- which takes the keeper from the app module).

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jun 7, 2024
@julienrbrt julienrbrt requested a review from a team as a code owner June 7, 2024 06:11
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 7, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

facundomedica
facundomedica approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we make it a pointer in main?

@julienrbrt
Copy link
Member Author

LGTM, should we make it a pointer in main?

So in main we don't need any of this, as we don't create accounts automatically.

@julienrbrt julienrbrt merged commit aeb1e8f into release/v0.50.x Jun 7, 2024
46 of 47 checks passed
@julienrbrt julienrbrt deleted the julien/updated-keepers branch June 7, 2024 12:34
@julienrbrt
Copy link
Member Author

@Mergifyio backport release/v0.47.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 7, 2024 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 7, 2024
@julienrbrt @mergify
refactor(x/authz,x/feegrant): provide updated keeper in depinject (#2…
254f3bd 
…0590)

(cherry picked from commit aeb1e8f)

# Conflicts:
#	CHANGELOG.md
#	x/authz/module/module.go
#	x/feegrant/module/module.go
@mergify mergify bot mentioned this pull request Jun 7, 2024
Merged
12 tasks
julienrbrt added a commit that referenced this pull request Jun 7, 2024
@mergify @julienrbrt
refactor(x/authz,x/feegrant): provide updated keeper in depinject (ba…
647907d 
…ckport #20590) (#20595)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@SpicyLemon SpicyLemon mentioned this pull request Jun 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica facundomedica approved these changes

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:x/authz C:x/feegrant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienrbrt @facundomedica