Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.34.0 (develop) #4086

Merged
merged 47 commits into from Apr 15, 2019
Merged

Release v0.34.0 (develop) #4086

merged 47 commits into from Apr 15, 2019

Conversation

alexanderbez
Copy link
Contributor

Release v0.34.0 into develop. PR into master: #4036.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #4086 into develop will decrease coverage by <.01%.
The diff coverage is 17.07%.

@@             Coverage Diff             @@
##           develop    #4086      +/-   ##
===========================================
- Coverage    59.96%   59.95%   -0.01%     
===========================================
  Files          211      211              
  Lines        15111    15131      +20     
===========================================
+ Hits          9061     9072      +11     
- Misses        5430     5437       +7     
- Partials       620      622       +2

CHANGELOG.md Show resolved Hide resolved
@alexanderbez alexanderbez merged commit ea8539e into develop Apr 15, 2019
@alessio alessio deleted the release/v0.34.0 branch August 11, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants