Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove viper global single from x/staking #6631

Merged
merged 13 commits into from
Jul 8, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Jul 7, 2020

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #6631 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6631      +/-   ##
==========================================
- Coverage   57.58%   57.50%   -0.09%     
==========================================
  Files         500      500              
  Lines       29999    30024      +25     
==========================================
- Hits        17275    17264      -11     
- Misses      11479    11515      +36     
  Partials     1245     1245              

@alexanderbez alexanderbez mentioned this pull request Jul 7, 2020
27 tasks
@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2020

This pull request introduces 1 alert when merging a7d4a58 into a459b78 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@jgimeno jgimeno marked this pull request as ready for review July 8, 2020 19:47
@alexanderbez alexanderbez added C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. C:x/staking labels Jul 8, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio alessio merged commit a417b38 into master Jul 8, 2020
@alessio alessio deleted the jonathan/viper-staking-module branch July 8, 2020 20:00
@alessio alessio changed the title Remove viper in Staking module. Remove viper global single from x/staking Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/staking Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants