[backports] v0.40.0-rc1 #7590

clevinson · 2020-10-19T05:40:24Z

Description

This PR contains cherry-picks for all merged PRs into master with the backport/0.40.x (Stargate) label. Alternatively, it may have been better practice to have separate backport PRs for each PR int master, but due to the number of backports I decided to make one bulk PR for all pending backports so far to accelerate the process for rc1.

This next release candidate must be published by EOD Monday (10/19/20), in order for @zmanian to be able to use it for his upcoming hub testnet. Of the open PRs into master with backport/0.40.x (Stargate), only #7549 and #7594 are blocking an rc1 (per @zmanian's request).

Backports in this PR:

The following larger pieces that may be included in rc1 if they are fully wrapped up by EOD Monday are:

Remove bech32 PubKey support Remove bech32 PubKey support #7477
Implement ADR031 (Protobuf Message Services) Implement Protobuf Msg Services #7540

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

* Remove deprecated docs and add first guidelines to protobuf migration * Add conventions * Reorder and add more FAQ doc * Update guidelines for pb msg definitions * Use commit hash in github links Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Prettier * docs: Update "Basics" section * appcli -> appd * Better wording * Fix to appCodec * Add gRPC mention * Add grpc * Reference simapp code * Update docs/basics/accounts.md Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Add section about gRPC query services * Optional LegacyQuerierHandler * Clearer docs * Update docs/basics/app-anatomy.md Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Update docs/basics/app-anatomy.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Address comments * Address comments * Update docs/basics/accounts.md Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* add timestamp to SignatureAndData Add timestamp field to signature and data. Add ValidateBasic check for timestamp. Add ValidateBasic test. Update misbehaviour handler to use supplied timestamp. * fix typo * add timestamp check * fix lint Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* update solo machine specs * update concepts * self review fixes * Apply suggestions from code review * add note on upgarding solo machines Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* update sdk to rc5 * Update baseapp/params.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.0.0...v1.1.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@fedekunze

* remove test_utils from tm client * fix build * fix lint? * fix lint? * apply @fedekunze review suggestion * add tests as per @alessio suggestion * fix typo

* Update module-manager.md * Update modules #messages doc * Fix typo * Update message implementation example link * Update messages-and-queries.md#queries doc * Update querier.md * Update handler.md * Update links in beginblock-endblock.md * Update keeper.md * Update invariants.md * Update genesis.md * Update module-interfaces.md#transaction-commands * Update module-interfaces.md#query-commands * Update module-interfaces.md#flags * Update module-interfaces.md#rest * Update structure.md * Update module-interfaces.md#grpc * Update errors.md * Update module-interfaces.md#grpc-gateway-rest * Add more info on swagger * Address comments * Fix go.sum * Fix app-anatomy.md * Update docs/building-modules/module-interfaces.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update docs/building-modules/querier.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update docs/building-modules/querier.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update docs/building-modules/module-interfaces.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Update docs/building-modules/module-interfaces.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Address part of review comments * Update old ref of RegisterQueryService * Add example code for Manager * Update queriers.md to query-services.md and refs * Add new query-services.md * Revert "Update old ref of RegisterQueryService" This reverts commit 1ea1ea8. * Update keeper.md * Update handler.md * Update handler.md * Update messages-and-queries.md * Update docs/basics/app-anatomy.md Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> * Update docs/building-modules/intro.md Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> * Fix typo Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>

…7558) * client: add GetAccount and GetAccountWithHeight to AccountRetriever * update ADR * address comments from review

* Add the option of emitting amino encoded json * Update AMINO JSON serialization with ConvertTxToStdTx * Make the Amino flag more self documenting by serializing the BroadcastRequest type instead of StdTx * Handle amino encoding error * Update x/auth/client/cli/tx_multisign.go Co-authored-by: Alessio Treglia <alessio@tendermint.com> * Update x/auth/client/cli/tx_sign.go Co-authored-by: Alessio Treglia <alessio@tendermint.com> * Apply suggestions from code review Co-authored-by: Alessio Treglia <alessio@tendermint.com> * Fix go format Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

) * Revert some changes from #7404 * Update x/slashing * Address review comments * Small tweak Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>

clevinson · 2020-10-19T05:45:14Z

Note this does not include #7499, which @amaurymartiny has a separate backport PR for (#7516)

CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* fix solo machine cli cmds * polish Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

zmanian · 2020-10-19T14:39:16Z

I expext the validators will perceive #7594 as significant enough to be a must have in rc1.

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

codecov · 2020-10-19T19:06:23Z

Codecov Report

❗ No coverage uploaded for pull request base (v0.40.x@3dd64be). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v0.40.x    #7590   +/-   ##
==========================================
  Coverage           ?   54.84%           
==========================================
  Files              ?      595           
  Lines              ?    38015           
  Branches           ?        0           
==========================================
  Hits               ?    20851           
  Misses             ?    15040           
  Partials           ?     2124

* iavl 0.15.0-rc4 version bump * update comments on error modes for store.LoadStore * update CONFIO_URL in makefile Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

…7594) * Handle nil any in UnpackAny * Add test * Add flag back * Update runTx signature * Update Simulate signature * Update calls to Simulate * Add txEncoder in baseapp * Fix TestTxWithoutPublicKey * Wrap errors * Use amino in baseapp tests * Add txEncoder arg to Check & Deliver * Fix gas in test * Fix remaining base app tests * Rename to amionTxEncoder * Update codec/types/interface_registry.go Co-authored-by: Aaron Craelius <aaron@regen.network> * golangci-lint fix Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Cory Levinson <cjlevinson@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

…ckports-0.40.0-rc1

aaronc

ACK

zmanian

Has all needed backports AFAIK.

blushi and others added 17 commits October 18, 2020 21:35

update solo machine specs (#7512)

48dab9f

* update solo machine specs * update concepts * self review fixes * Apply suggestions from code review * add note on upgarding solo machines Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Corrected 'unsafe-reset-all' help text (#7504)

cc5146c

Merge PR #7415: Return empty store tree on non-existing version

b61f3eb

tendermint: update sdk to rc5 (#7527)

79ee6c6

* update sdk to rc5 * Update baseapp/params.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

remove test_utils.go in tm client (#7522)

9b301fc

* remove test_utils from tm client * fix build * fix lint? * fix lint? * apply @fedekunze review suggestion * add tests as per @alessio suggestion * fix typo

ibc: cleanup channel types test (#7521)

86b87c4

client: add GetAccount and GetAccountWithHeight to AccountRetriever (#…

1b75a6d

…7558) * client: add GetAccount and GetAccountWithHeight to AccountRetriever * update ADR * address comments from review

ibc: update solo machine client command (#7579)

8e256b2

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

remove id in localhost (#7577)

ab8f89f

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>

update changelog

0d64056

clevinson mentioned this pull request Oct 19, 2020

Fix solomachine cmds #7581

Merged

9 tasks

amaury1093 mentioned this pull request Oct 19, 2020

backport: Use enum instead of int32 for BondStatus (#7499) #7516

Merged

alexanderbez reviewed Oct 19, 2020

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

clevinson and others added 2 commits October 19, 2020 07:07

Update CHANGELOG.md

0de50cc

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Fix solomachine cmds (#7581)

2f1764c

* fix solo machine cli cmds * polish Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

simapp: use tmjson on InitChainer (#7514)

182b01c

Co-authored-by: Alessio Treglia <alessio@tendermint.com>

clevinson and others added 2 commits October 19, 2020 12:07

[IAVL]: Bump to v0.15.0-rc4 (#7549)

77dd62b

* iavl 0.15.0-rc4 version bump * update comments on error modes for store.LoadStore * update CONFIO_URL in makefile Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

clevinson mentioned this pull request Oct 19, 2020

[backport/v0.40.x] Implement ADR031 #7599

Merged

9 tasks

Merge remote-tracking branch 'origin/v0.40.x' into clevinson/first-ba…

2619b40

…ckports-0.40.0-rc1

clevinson marked this pull request as ready for review October 19, 2020 20:19

clevinson requested review from aaronc and alessio as code owners October 19, 2020 20:19

aaronc approved these changes Oct 19, 2020

View reviewed changes

aaronc added A:automerge Automatically merge PR once all prerequisites pass. T: Proto Breaking Protobuf breaking changes: generally don't do this! labels Oct 19, 2020

clevinson requested a review from zmanian October 19, 2020 20:30

zmanian approved these changes Oct 19, 2020

View reviewed changes

clevinson merged commit d2a6cce into v0.40.x Oct 19, 2020

clevinson deleted the clevinson/first-backports-0.40.0-rc1 branch October 19, 2020 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backports] v0.40.0-rc1 #7590

[backports] v0.40.0-rc1 #7590

clevinson commented Oct 19, 2020 •

edited

clevinson commented Oct 19, 2020 •

edited

zmanian commented Oct 19, 2020

codecov bot commented Oct 19, 2020 •

edited

aaronc left a comment

zmanian left a comment

[backports] v0.40.0-rc1 #7590

[backports] v0.40.0-rc1 #7590

Conversation

clevinson commented Oct 19, 2020 • edited

Description

clevinson commented Oct 19, 2020 • edited

zmanian commented Oct 19, 2020

codecov bot commented Oct 19, 2020 • edited

Codecov Report

aaronc left a comment

Choose a reason for hiding this comment

zmanian left a comment

Choose a reason for hiding this comment

clevinson commented Oct 19, 2020 •

edited

clevinson commented Oct 19, 2020 •

edited

codecov bot commented Oct 19, 2020 •

edited