Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in querying events #8773

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix typo in querying events #8773

merged 1 commit into from
Mar 3, 2021

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Mar 3, 2021

Description

closes #8760

introduced in #8512 (comment), too bad the gogoproto-generated files don't export those as constants.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #8773 (f008249) into master (91affb5) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8773   +/-   ##
=======================================
  Coverage   61.38%   61.39%           
=======================================
  Files         672      672           
  Lines       38390    38404   +14     
=======================================
+ Hits        23565    23577   +12     
- Misses      12341    12342    +1     
- Partials     2484     2485    +1     
Impacted Files Coverage Δ
x/staking/client/rest/query.go 40.66% <ø> (ø)
x/staking/types/msg.go 23.92% <ø> (ø)
x/ibc/core/02-client/types/encoding.go 60.00% <77.77%> (+6.15%) ⬆️
types/address.go 66.00% <100.00%> (+0.13%) ⬆️
x/ibc/core/02-client/keeper/client.go 98.27% <100.00%> (+0.06%) ⬆️

@sahith-narahari sahith-narahari added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 3, 2021
@mergify mergify bot merged commit eef8d4d into master Mar 3, 2021
@mergify mergify bot deleted the am/8760-typo branch March 3, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Bug: Reference to Msg/Deledate
3 participants