evm: various fixes #319
evm: various fixes #319
Conversation
| @@ -75,6 +75,7 @@ func NewGenesisStorage(key, value ethcmn.Hash) GenesisStorage { | |||
| func DefaultGenesisState() GenesisState { | |||
| return GenesisState{ | |||
| Accounts: []GenesisAccount{}, | |||
| TxsLogs: []TransactionLogs{}, | |||
| logs, err := s.GetLogs(ch.txhash) | ||
| if err != nil { | ||
| // panic on unmarshal error | ||
| panic(err) |
There was a problem hiding this comment.
This is an internal error that is only present is there's an unmarshal error. We want to panic here bc otherwise we could persist invalid state and have to manually stop the chain (which requires coordination of +1/3 validatiors) and then roll-back to the height before the first error instance of this error occurred.
Having a panic prevents this overhead and allows us to detect these errors during development 🙂
|
@noot this is ready for review again. I'll write tests for the logs validations after I finish the WebSocket PR |
|
@fedekunze I think this causes some issue with transaction receipts, I ran the rpc tests and the or |
Description
SetBlockBloomtoEndBlockFor contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)