Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

add gas price=0 unit test, comments #528

Merged
merged 3 commits into from
Sep 23, 2020
Merged

add gas price=0 unit test, comments #528

merged 3 commits into from
Sep 23, 2020

Conversation

noot
Copy link
Contributor

@noot noot commented Sep 23, 2020

Closes: #XXX

Description

follow up to #515 , #516


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot self-assigned this Sep 23, 2020
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #528 into development will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #528      +/-   ##
===============================================
+ Coverage        70.60%   70.77%   +0.17%     
===============================================
  Files               41       41              
  Lines             2320     2320              
===============================================
+ Hits              1638     1642       +4     
+ Misses             538      536       -2     
+ Partials           144      142       -2     
Impacted Files Coverage Δ
x/evm/handler.go 91.37% <ø> (ø)
x/evm/types/msg.go 67.39% <0.00%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4f7fb...7781961. Read the comment docs.

@noot noot merged commit a54c2dc into development Sep 23, 2020
@noot noot deleted the noot/comments branch September 23, 2020 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants