Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

ante: update nonce check #550

Merged
merged 4 commits into from Sep 29, 2020
Merged

ante: update nonce check #550

merged 4 commits into from Sep 29, 2020

Conversation

noot
Copy link
Contributor

@noot noot commented Sep 28, 2020

Closes: #544

Description

  • update nonce check in ante handler to reject nonces that are less than the current nonce

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #550 into development will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #550   +/-   ##
============================================
  Coverage        70.72%   70.72%           
============================================
  Files               42       42           
  Lines             2333     2333           
============================================
  Hits              1650     1650           
  Misses             540      540           
  Partials           143      143           
Impacted Files Coverage Δ
app/ante/eth.go 58.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee4c5f...17a4b8a. Read the comment docs.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending bugfix changelog entry too

app/ante/eth.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze changed the title update nonce check ante: update nonce check Sep 29, 2020
@noot noot merged commit 7f648d2 into development Sep 29, 2020
@noot noot deleted the noot/nonce branch September 29, 2020 14:39
@araskachoi araskachoi mentioned this pull request Oct 6, 2020
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject transaction sending a lot of transactions in a short period of time
2 participants