Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

atlas: evm module #651

Merged
merged 6 commits into from
Dec 10, 2020
Merged

atlas: evm module #651

merged 6 commits into from
Dec 10, 2020

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Dec 10, 2020 •
edited

published module on Atlas: https://atlas.cosmos.network/modules/3

@fedekunze fedekunze marked this pull request as ready for review December 10, 2020 21:37
@fedekunze fedekunze requested a review from noot as a code owner December 10, 2020 21:37
@fedekunze fedekunze self-assigned this Dec 10, 2020
@fedekunze fedekunze added documentation Improvements or additions to documentation automerge labels Dec 10, 2020
okwme
okwme reviewed Dec 10, 2020
View reviewed changes
x/evm/atlas/atlas-v0.3.1.md Outdated Show resolved Hide resolved
okwme
okwme reviewed Dec 10, 2020
View reviewed changes
x/evm/atlas/atlas-v0.3.1.md Outdated Show resolved Hide resolved
okwme
okwme approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@okwme okwme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor suggestions but otherwise LGTM

araskachoi
araskachoi reviewed Dec 10, 2020
View reviewed changes
x/evm/atlas/atlas-v0.3.1.md
func NewApp(...) *App {
// ...
app.EvmKeeper = evm.NewKeeper(
app.cdc, keys[evm.StoreKey], app.subspaces[evm.ModuleName], app.AccountKeeper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tab here

araskachoi
araskachoi reviewed Dec 10, 2020
View reviewed changes
x/evm/atlas/atlas-v0.3.1.md
)
```

8. Set the `x/evm` module genesis order. The module must go after the `auth` and `bank` modules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there supposed to be explicit instructions on how to set up the auth and bank modules?

araskachoi
araskachoi approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@araskachoi araskachoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things but lgtm

@mergify mergify bot merged commit 5782821 into development Dec 10, 2020
@mergify mergify bot deleted the evm-atlas branch December 10, 2020 22:31
@fedekunze fedekunze restored the evm-atlas branch December 10, 2020 22:31
fedekunze added a commit that referenced this pull request Dec 14, 2020
@fedekunze @araskachoi
@dependabot @summerpro @okwme
stargate: fix conflicts (#650)
ede2dbc 
* deps: update to cosmos-sdk v0.39.2-rc3 (#608)

* update to cosmos-sdk v0.39.2

* fix HD path test

* changelog (#609)

* build: require go 1.15+ (#610)

* evm: state transitions enabled params (#603)

* changelog

* evm: state transitions enabled params

* changelog entry

* changelog

* deps: bump cosmos-sdk version to v0.39.2 (#615)

* deps: bump cosmos-sdk version to v0.39.2

* changelog

* rpc: fix deadlock (#614)

* update tools configs (#611)

* update tools configs

* minor updates

* add jq (#616)

* build(deps): bump gopkg.in/yaml.v2 from 2.3.0 to 2.4.0 (#622)

Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/go-yaml/yaml/releases)
- [Commits](go-yaml/yaml@v2.3.0...v2.4.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* app: fix export genesis (#619)

* v0.3.1 changes

* fix export genesis

* changelog

* evm: fix genesis format mismatch (#623)

* evm: fix genesis format mismatch

* genesis tests

* fix test

* changelog

* nolint

* force build-ethermint and cleanup stdout (#628)

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* join network doc (#606)

* join network doc

* include faucet instructions

* add rpc instructions

* edit persistent peers

* update to latest testnet

* evm: implement vm.GetHashFn (#620)

* evm: implement vm.GetHashFn

* check nil case

* test

* handle 3 cases

* use switch statement

* stateDB tests

* abci changes

* fix LGTM issue

* final tests

* changelog

* remove epoch

* update test

* clean test

* rm epoch

* open Istanbul and MuirGlacier from ChainConfig (#645)

* open Istanbul and MuirGlacier

* fix ut

* fix ut

* evm: extra eips param (#643)

* evm: extra eips param

* changelog

* rpc: protocol version (#575)

* evm: protocol version

* changelog

* version

* fix

* support latest version only

* evm: module specification (#538)

* evm: module specification

* params and events

* readme and messages

* minor updates

* concepts

* genesis state concept

* begin and end block

* update parameters and genesis

* state objects

* state table

* use permalink

* init and export genesis

* update abci

* extra eips param

* review comments

* precision

* link to photon doc

* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#649)

Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.8 to 1.0.9.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.8...7481451)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* stargate: fix conflicts

* more fixes

* proto changes

* more tendermint changes

* test fixes

* atlas: evm module (#651)

* atlas: evm module

* typos

* update toml

* update description

* Update x/evm/atlas/atlas-v0.3.1.md

* Update x/evm/atlas/atlas-v0.3.1.md

Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>

* build(deps): bump actions/setup-node from v2.1.2 to v2.1.3 (#653)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.2 to v2.1.3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v2.1.2...27082ce)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/ethereum/go-ethereum from 1.9.24 to 1.9.25 (#654)

* build(deps): bump github.com/ethereum/go-ethereum from 1.9.24 to 1.9.25

Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.9.24 to 1.9.25.
- [Release notes](https://github.com/ethereum/go-ethereum/releases)
- [Commits](ethereum/go-ethereum@v1.9.24...v1.9.25)

Signed-off-by: dependabot[bot] <support@github.com>

* fixes

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#652)

Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.9 to 1.0.10.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.9...72d871b)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

* update peers (#656)

* update peers

* update chainid in cmd

* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#659)

Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.10 to 1.0.11.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.10...2a60e0f)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ini from 1.3.5 to 1.3.8 in /docs (#658)

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Daniel Choi <choidanielw@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pierre <974741468@qq.com>
Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@okwme okwme okwme approved these changes

@araskachoi araskachoi araskachoi approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@noot noot Awaiting requested review from noot

Assignees

@fedekunze fedekunze

Labels
automerge documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fedekunze @okwme @araskachoi