refactor bypass-min-fee-msg-types

[yaruwangway]

Summary

Presently, gaia allows certain message free of fee charge, the default setup in app.toml is:

bypass-min-fee-msg-types = ["/ibc.core.channel.v1.MsgRecvPacket", 
"/ibc.core.channel.v1.MsgAcknowledgement", 
"/ibc.core.client.v1.MsgUpdateClient"]

Nodes created using Gaiad v7.0.2 or later will have the above bypass-min-fee-msg-types as defaults in app.toml. Nodes with bypass-min-fee-msg-types = [] or missing this field in app.toml also use default bypass message types.

Bypass-msgs should not exceed gas usage of uint64(len(bypassMsgs))*MaxBypassMinFeeMsgGasUsage. MaxBypassMinFeeMsgGasUsage = 200,000.

Type

Impact

There will be more msgs from relayers free of fee charges.

Proposed Solution

The following changes are proposed:

• Nodes with bypass-min-fee-msg-types = [], will not bypass any message, node with bypass-min-fee-msg-types missing in app.toml will use default bypass-min-fee-msg-types change bypass-min-fee-types parsing; change defaults #2092, corresponding docs need to be updated.
• add ["/ibc.core.channel.v1.MsgTimeout", "/ibc.core.channel.v1.MsgTimeoutOnClose"] to default ypass-min-fee-msg-types
• bypass-msg should not exceed an arbitrary MaxTotalBypassMinFeeMsgGasUsage, this MaxTotalBypassMinFeeMsgGasUsage should be smaller than half of a block's max_gas so that other messages can also get into the block. With MaxTotalBypassMinFeeMsgGasUsage, relayers can arrange the bypass-msgs to utilize the bypass setup.
  from cosmoshub-4 genesis, we can get

 "block": {
    "max_bytes": "200000",
    "max_gas": "2000000",
    "time_iota_ms": "1000"
  }

so the MaxTotalBypassMinFeeMsgGasUsage can be 1,000,000

• add unit tests and test manually.
  • Add tests for multiple bypass msg in one tx.
  • Add tests for mixing bypass and non-bypass msg in one tx.

Discussion

1. in the future, shall we write bypass-min-fee-msg-types and MaxTotalBypassMinFeeMsgGasUsage to the store ?

2. there are difference voices also if we write MaxTotalBypassMinFeeMsgGasUsage to app.toml together with bypass-min-fee-msg-types

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?

[yaruwangway]

Hi @jtremback, the reason I propose to move bypass-min-fee-msg-types to v9.0.1 or v8 is:
v10 will have sdk 0.47, in sdk0.47, params module is deprecated, that means globalfee will have a store migration, fee ante handler will also have a refactor as well. So I am thinking if we can move part of the minor changes earlier ?

[yaruwangway]

@MSalopek , do we need to fix the extra , in the bypass-min-fee-msg-types in app.tom ?

bypass-min-fee-msg-types = ["/ibc.core.channel.v1.MsgRecvPacket", 
"/ibc.core.channel.v1.MsgAcknowledgement", 
"/ibc.core.client.v1.MsgUpdateClient", ]

[yaruwangway]

Hi @ancazamfir , thank you for the thoughtful input and discussion ! ❤️
just let you know also about writing MaxTotalBypassMinFeeMsgGasUsage = 1,000,000 to app.toml is to be decided. The reason is: we might not want the MaxTotalBypassMinFeeMsgGasUsage adjusted by each node.

anyway, like discussed, writing both MaxTotalBypassMinFeeMsgGasUsage and bypass-msg to store might be a future option.

[ancazamfir]

we might not want the MaxTotalBypassMinFeeMsgGasUsage adjusted by each node.

Who is "we"? How is this different than operator preference to have gas fee configurable? I am trying to understand and as I mentioned I don't know why some params are in app.toml vs in genesis.json and how a decision was reached for these?
For MaxTotalBypassMinFeeMsgGasUsage is there feedback from node operators? Or are there concerns that issues (like non-determinism) may occur due to different nodes setting this differently?

There might be some justification in this particular case but having a hardcoded param is generally not a good idea imho.

[yaruwangway]

I discussed with @MSalopek.

How is this different than operator preference to have gas fee configurable?

do you mean setup --gas when submit tx ? tx submitter can set up this very high but they have pay, but if MaxTotalBypassMinFeeMsgGasUsage is setup high, there might be no space left for other types of tx in a block.
I can ask also node operators if they prefer to setup this value or agree to use the same.

[yaruwangway]

Hi @mmulji-ic, for software design related feedback from node operators (like above), what is the best channel to ask, validator-verified ? thanks!

[mmulji-ic]

I slacked you some channels, if you don't get enough feedback, I can reach out to validators via telegram. IBC devrel would be good to get some input also.

[yaruwangway]

Hi @ancazamfir, just to correct what i said, changing gas is state-breaking. please check here #2218 (comment)

so MaxTotalBypassMinFeeMsgGasUsage cannot stay in app.toml and this refactor need an upgrade.

[yaruwangway]

closed by pr #2218