-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change bypass-min-fee-types parsing; change defaults #2092
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 83.84% 83.40% -0.44%
==========================================
Files 22 22
Lines 1541 1555 +14
==========================================
+ Hits 1292 1297 +5
- Misses 201 207 +6
- Partials 48 51 +3
|
f7e198b
to
3ff620b
Compare
we can add some e2e tests, let me know if you want me to add it |
this pr will be finally refactored. please see this issue. but lets still get it merged first, in case any decision changes later |
a058213
to
1620478
Compare
changelog need to be added before merge. |
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
* change bypass-min-fee-types parsing; change defaults * revert default message registration * docs: add changelog for fixing bypass parsing * Update CHANGELOG.md Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> --------- Co-authored-by: Yaru Wang <yaru@informal.systems> Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> (cherry picked from commit 4badbcd) # Conflicts: # CHANGELOG.md
…#2311) * change bypass-min-fee-types parsing; change defaults (#2092) * change bypass-min-fee-types parsing; change defaults * revert default message registration * docs: add changelog for fixing bypass parsing * Update CHANGELOG.md Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> --------- Co-authored-by: Yaru Wang <yaru@informal.systems> Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> (cherry picked from commit 4badbcd) # Conflicts: # CHANGELOG.md * resolve conflict in changelog * debug upgrade script * bump cosmovisor --------- Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
Closes: #2087
Parsing of
bypass-min-fee-types
is changed to allow operators to use empty bypass list.The default was changed to be an empty list (no bypass allowed).
Removing the
bypass-min-fee-types
fromapp.toml
will cause the default list of types to be used.Validation was added so strings not corresponding to any proto message types will cause a panic (since this is a misconfiguration, manual action should be required)
Logging was added to inform operators about bypass usage.
Behaviour
no key in the config file
key =
key = [ ]
key = ["value1", "value2"]