Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SPM #2388

Closed
faddat opened this issue Apr 9, 2023 · 4 comments
Closed

Remove SPM #2388

faddat opened this issue Apr 9, 2023 · 4 comments
Labels
more-info-needed Further information is requested

Comments

@faddat
Copy link
Contributor

faddat commented Apr 9, 2023

The cosmos hub contains a deprecated software component. Today I was working with a team member to fix issues with queries that are mentioned in #2313.

 gaia % go mod tidy
go: downloading github.com/cosmos/cosmos-sdk v0.45.16-ics
go: github.com/tendermint/spm@v0.1.9 requires
	github.com/cosmos/cosmos-sdk@v0.44.3: reading github.com/cosmos/cosmos-sdk/go.mod at revision v0.45.16-ics: unknown revision v0.45.16-ics

Here's various related work:

This removes ICS from the hub and allows these fixes to happen.

That makes the hubs sdk version match the one used in ics. Hub main branch uses 45.15. Ics should too.

That will make ics use the latest IBC. The hub should do that too.

So, thing is, if you try and use a patched cosmos-sdk, as we did here:

@mpoke
Copy link
Contributor

mpoke commented Apr 21, 2023

@faddat Thank you for opening an issue. Could you please give more context on the problem and the desire closing criteria?

Also note that at the moment there is no v0.45.16-ics release. The latest is v0.45.15-ics.

go: downloading github.com/cosmos/cosmos-sdk v0.45.16-ics

@mpoke mpoke added the more-info-needed Further information is requested label Apr 21, 2023
@faddat
Copy link
Contributor Author

faddat commented Apr 28, 2023

I am here to provide more information if needed. So you see SPM is an archived repository that was last worked on in January of 2022. It has caused chain halts.

It has also broken CLIs, and it causes chains to diverge from the normal path of development. Now in Gaia case, it may not be that severe, however, it's really best that it just not be in our precious Gaia.

@mpoke
Copy link
Contributor

mpoke commented Apr 28, 2023

Is #2442 going to fix this issue?

@mpoke
Copy link
Contributor

mpoke commented May 12, 2023

Fixed by #2442

@mpoke mpoke closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-info-needed Further information is requested
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants