-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps!: bump ibc-go to v4.3.0 and remove dragonberry replace #2185
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8eb2345
bumps for gaia main branch
faddat 0e18173
tidy and remove unexplained go.mod section
faddat 2c22fa0
Merge branch 'main' into bumps-for-main
glnro 822c868
Merge branch 'main' into bumps-for-main
glnro 1912283
Merge branch 'main' into bumps-for-main
mpoke d782f00
Merge branch 'main' into bumps-for-main
faddat e85be53
fix gogoproto/protobuf import
faddat c766517
revert to ics 1.1.0
faddat 74d20a3
Merge branch 'main' into bumps-for-main
mpoke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the PR contained to one issue. There is no need to bump the version of ICS in the same PR where we bump ibc-go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/cosmos/interchain-security/blob/6a856d183cd6fc6f24e856e0080989ab53752102/go.mod#L31
there is. At least, while I do understand that gaia's version will dominate, I've seen a lot of kaboomies.
To prevent them I like to ensure that dependencies use the exact same versions of ecosystem libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert, but wish to note that I think it is safer to group this stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faddat Thank you for sharing your concern. If you think that bumping ibc-go to v4.3.0 requires a bump of ICS as well, please open an issue describing the problem in details. We can discuss your concerns on that issue and decide on how to best address them.
From the description and title of this PR, the goal is to
Adding multiple changes to the same PR without properly documenting it, will lead to difficulties in maintaining Gaia in the long run. For example,
github.com/cosmos/interchain-security v1.2.0contains multiple changes that need to be properly tested before adding them to Gaia. Moreover, v1.2.0 still uses ibc-go v4.2.0.