Sainoe/globalfee coins #2378
Merged
Sainoe/globalfee coins #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.51.2 to 1.52.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.51.2...v1.52.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.19...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
sainoe
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
MSalopek and
shaspitz
as code owners
yaruwangway
approved these changes
Apr 6, 2023
mmulji-ic
added a commit
that referenced
this pull request
Apr 12, 2023
* - Update doc to follow Go conventions - Improve code readability * update params * rebase and fix nits * add GetMinGasPrice UT * remove unused feetestsuite * rebase * update doc * nits * nits * refactor fee tests setup * remove comments * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * Update x/globalfee/ante/antetest/fee_test.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * Update x/globalfee/ante/antetest/fee_test.go * fix GetMinGasPrice to not return nil coins * min gas price zero coins edge cases * min gas price zero coins edge cases * remove debug logs * udpate comments * udpate comments * add comment * Update x/globalfee/types/params.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * Update x/globalfee/types/params.go Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> * fix: lint Signed-off-by: Yaru Wang <yaru@informal.systems> * refactor: global fee zero coins * refactor: add splitGlobalFees() * fix: globalfee antehandler * fix: add test helper func * update according to PR comments * test: add test for splitGlobalFees() * code improvement * refactor: globalfee antehandler * refactor: bypass logic * refactor: fee check logic * fix: lint * fix: return err when required fees are not set up * chore: clean comments * Sainoe/globalfee coins (#2378) * chore(deps): bump github.com/golangci/golangci-lint (#2319) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.51.2 to 1.52.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.51.2...v1.52.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> * chore(deps): bump github.com/docker/docker (#2365) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.19...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Removed trust node in docs (#2359) * update ditrosless image url in Dockerfiles * nits --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> * fix nits --------- Signed-off-by: Yaru Wang <yaru@informal.systems> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marius Poke <marius.poke@posteo.de> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.