Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add rate limit module #3002

Merged
merged 18 commits into from
Mar 25, 2024
Merged

feat!: add rate limit module #3002

merged 18 commits into from
Mar 25, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Mar 14, 2024

Description

Closes: #3000


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the timeout on e2e tests to 30-35 minutes.

Upgrade test is expected to fail since v16 upgrade handlers don't work correctly - that's for another PR.

@mpoke
Copy link
Contributor Author

mpoke commented Mar 20, 2024

You need to bump the timeout on e2e tests to 30-35 minutes.

It's already 45m, i.e.,

  test-e2e:
    runs-on: ubuntu-latest
    timeout-minutes: 45

@mpoke mpoke requested review from sainoe and MSalopek March 20, 2024 12:09
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for adding the tests.

@MSalopek MSalopek mentioned this pull request Mar 25, 2024
18 tasks
@MSalopek MSalopek merged commit 62cb8ae into main Mar 25, 2024
17 checks passed
@MSalopek MSalopek deleted the marius/rate-limit-module branch March 25, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBC Rate Limit integration
3 participants