rules/sdk: exclude "testutil" from map ranging checks #51
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change excludes: * "gogoreflection" * "simapp" * "simulation" * "testutil" from map ranging checks given that such code is used for testing and no need to flag natural code to iterate over tests. Fixes #50
odeke-em
force-pushed
the
sdk-no-map-ranging-over-testutil-packages
branch
from
f404ef7
to
cffc933
Compare
Codecov ReportBase: 71.77% // Head: 71.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 9 9
Lines 627 627
=======================================
Hits 450 450
Misses 149 149
Partials 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change excludes "testutil" from map ranging checks given that such code is used for testing and no need to flag natural code to iterate over tests.
Fixes #50