Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules/sdk: skip map iteration checks for testutil code #50

Closed
odeke-em opened this issue Sep 24, 2022 · 0 comments · Fixed by #51
Closed

rules/sdk: skip map iteration checks for testutil code #50

odeke-em opened this issue Sep 24, 2022 · 0 comments · Fixed by #51
Assignees
@odeke-em
Labels
bug Something isn't working

Comments

@odeke-em
Copy link
Collaborator

We are getting reports such as in
Screen Shot 2022-09-23 at 7 44 56 PM

that code shouldn't be flagged as invalid and it should be natural for testutil code to iterate over maps.
@odeke-em odeke-em added the bug Something isn't working label Sep 24, 2022
@odeke-em odeke-em self-assigned this Sep 24, 2022
odeke-em added a commit that referenced this issue Sep 24, 2022
@odeke-em
rules/sdk: exclude "testutil" from map ranging checks
f404ef7 
This change excludes "testutil" from map ranging checks
given that such code is used for testing and no need to flag
natural code to iterate over tests.

Fixes #50
@odeke-em odeke-em mentioned this issue Sep 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odeke-em odeke-em

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rules/sdk: exclude "testutil" from map ranging checks cosmos/gosec
1 participant
@odeke-em