Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "prefix" arg to iaviewer #396

Merged
merged 12 commits into from
Aug 18, 2021
Merged

add "prefix" arg to iaviewer #396

merged 12 commits into from
Aug 18, 2021

Conversation

summerpro
Copy link
Contributor

@summerpro summerpro commented May 18, 2021

The pr can support access to the data in the iavl tree of different modules of cosmos-sdk

In cosmos-sdk, the different modules under x/ use different iavl trees and are stored in the same leveldb (application.db). Different db prefixes are used to distinguish different modules, such as "s/k: gov/", "s/k:staking/", "s/k:evm/".

Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Left a suggestion and we need to update the function godoc as well.

cmd/iaviewer/main.go Show resolved Hide resolved
cmd/iaviewer/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGELOG as well.

@summerpro
Copy link
Contributor Author

Please update the CHANGELOG as well.

done

@robert-zaremba robert-zaremba added the S:automerge Automatic merge and/or update Pull requests label May 28, 2021
@summerpro
Copy link
Contributor Author

hi @robert-zaremba , can this pr be merged?

@summerpro summerpro closed this Jun 25, 2021
@summerpro summerpro reopened this Jun 25, 2021
@summerpro summerpro closed this Jun 25, 2021
@summerpro summerpro reopened this Jun 25, 2021
@summerpro summerpro closed this Jun 25, 2021
@summerpro summerpro reopened this Jun 25, 2021
@summerpro summerpro marked this pull request as draft June 25, 2021 11:22
@summerpro summerpro marked this pull request as ready for review June 25, 2021 11:22
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a good UX improvement.

@robert-zaremba robert-zaremba merged commit 29e1194 into cosmos:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatic merge and/or update Pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants