Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module account and sub accounts for ICS20 escrow addresses #330

Open
3 tasks
colin-axner opened this issue Aug 12, 2021 · 1 comment
Open
3 tasks

Use module account and sub accounts for ICS20 escrow addresses #330

colin-axner opened this issue Aug 12, 2021 · 1 comment
Labels
20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@colin-axner
Copy link
Contributor

Summary

Currently, ICS20 escrow addresses use a prefix and hash of the port/channel to generate the address. Careful consideration was made to ensure these addresses would not conflict with one another. Now that v0.43 of the SDK has implemented ADR 28, we should eventually migrate our escrow addresses to using a module account and sub accounts for each escrow address.

This solution is low priority since the current implementation was determined to be secure, but only with the portID "transfer". I'm unsure if using the ADR 28 solution would allow us to lift the maximum channel sequence requirement


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@colin-axner
Copy link
Contributor Author

see comment for more details

@crodriguezvega crodriguezvega added 20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants