Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate counterpartyChosenConnectionID checks in ConnOpenTry + ConnOpenAck #43

Closed
cwgoes opened this issue Oct 30, 2020 · 2 comments
Closed

Deduplicate counterpartyChosenConnectionID checks in ConnOpenTry + ConnOpenAck #43

cwgoes opened this issue Oct 30, 2020 · 2 comments
Labels
core good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Oct 30, 2020

As title.
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces core good first issue Good for newcomers labels Apr 21, 2021
@colin-axner
Copy link
Contributor

The duplication occurs between the message validation (msg.ValidateBasic) and the handshake handlers

faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jtieri @jackzampolin
Merge PR #43: Add Juno & e-money metadata
3dda799 
* add metadata for Juno

* add metadata for e-money

* add metadata for e-money
@colin-axner
Copy link
Contributor

closed a long time ago in SDK#7993

CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Merge pull request cosmos#43 from lazyledger/tzdybal/lint
39eaafe 
Enable golangci-lint GitHub action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwgoes @colin-axner