add ica module to simulation manager #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
colin-axner
approved these changes
Sep 12, 2022
RaulBernal
approved these changes
Sep 12, 2022
| @@ -604,6 +604,7 @@ func NewSimApp( | |||
| authzmodule.NewAppModule(appCodec, app.AuthzKeeper, app.AccountKeeper, app.BankKeeper, app.interfaceRegistry), | |||
| ibc.NewAppModule(app.IBCKeeper), | |||
| transfer.NewAppModule(app.TransferKeeper), | |||
| ica.NewAppModule(&app.ICAControllerKeeper, &app.ICAHostKeeper), | |||
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2252 +/- ##
==========================================
+ Coverage 79.51% 79.54% +0.02%
==========================================
Files 175 175
Lines 12077 12069 -8
==========================================
- Hits 9603 9600 -3
+ Misses 2049 2045 -4
+ Partials 425 424 -1
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 80ea89a)
mergify bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> (cherry picked from commit 80ea89a)
crodriguezvega
added a commit
that referenced
this pull request
Sep 15, 2022
crodriguezvega
added a commit
that referenced
this pull request
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up from this comment.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes