chore: follow up for testing rest of methods on 07-tendermint light client module #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-light-client-module-entry-points
…to-light-client-module-entry-points
…ient-module-entry-points' of github.com:cosmos/ibc-go into charly/issue#6001-move-client-state-testing-to-light-client-module-entry-points
…to-light-client-module-entry-points
…to-light-client-module-entry-points
…to-light-client-module-entry-points
…to-light-client-module-entry-points
…to-light-client-module-entry-points
…ient-module-entry-points' of github.com:cosmos/ibc-go into charly/issue#6001-move-client-state-testing-to-light-client-module-entry-points
…to-light-client-module-entry-points
WalkthroughThe update enhances the testing coverage of the Tendermint light client module by introducing a set of new test functions. These tests cover various scenarios related to client messages, state updates, validations of client and consensus states, paths, proofs, delays, and error conditions, aiming to improve the reliability and thoroughness of testing in the module. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Base automatically changed from
charly/issue#6001-move-client-state-testing-to-light-client-module-entry-points
to
main
April 11, 2024 10:16
charleenfei
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
colin-axner
reviewed
Apr 23, 2024
colin-axner
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM, thanks @charleenfei
Do we still have metrics on code cov changes? Just curious that we still hit the same amount of lines of code
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
|
||
| // ensure counterparty state is committed | ||
| suite.coordinator.CommitBlock(suite.chainB) | ||
| trustedHeight := path.EndpointA.GetClientLatestHeight().(clienttypes.Height) |
There was a problem hiding this comment.
Ensure type assertion is checked to prevent potential panics.
- trustedHeight := path.EndpointA.GetClientLatestHeight().(clienttypes.Height)
+ trustedHeight, ok := path.EndpointA.GetClientLatestHeight().(clienttypes.Height)
+ suite.Require().True(ok, "type assertion should not fail")Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| trustedHeight := path.EndpointA.GetClientLatestHeight().(clienttypes.Height) | |
| trustedHeight, ok := path.EndpointA.GetClientLatestHeight().(clienttypes.Height) | |
| suite.Require().True(ok, "type assertion should not fail") |
modules/light-clients/07-tendermint/light_client_module_test.go
Outdated
Show resolved
Hide resolved
modules/light-clients/07-tendermint/light_client_module_test.go
Outdated
Show resolved
Hide resolved
modules/light-clients/07-tendermint/light_client_module_test.go
Outdated
Show resolved
Hide resolved
modules/light-clients/07-tendermint/light_client_module_test.go
Outdated
Show resolved
Hide resolved
modules/light-clients/07-tendermint/light_client_module_test.go
Outdated
Show resolved
Hide resolved
modules/light-clients/07-tendermint/light_client_module_test.go
Outdated
Show resolved
Hide resolved
damiannolan
approved these changes
May 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6001
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.Summary by CodeRabbit
light_client_module_test.goandupgrade_test.gofor improved coverage and validation of client and consensus states, paths, proofs, delays, and error conditions.