Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: follow up for testing rest of methods on 07-tendermint light client module #6135

Merged
merged 41 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
84c4470
move tests from client state to lcm, use lcm entry point
charleenfei Apr 2, 2024
001b8e1
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 2, 2024
2e8d7db
linter
charleenfei Apr 2, 2024
903d4d6
update Initialise test + coverage
charleenfei Apr 2, 2024
a1f831c
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 2, 2024
d500532
linter
charleenfei Apr 2, 2024
ac8271d
Merge branch 'charly/issue#6001-move-client-state-testing-to-light-cl…
charleenfei Apr 2, 2024
edf7a68
import naming
charleenfei Apr 2, 2024
c197b77
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 3, 2024
82f61d4
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 8, 2024
cad7be3
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 8, 2024
4ee5664
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 9, 2024
6a0a755
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 9, 2024
f3d5764
update for pr review
charleenfei Apr 9, 2024
779971e
Merge branch 'charly/issue#6001-move-client-state-testing-to-light-cl…
charleenfei Apr 9, 2024
37bd55a
Merge branch 'main' into charly/issue#6001-move-client-state-testing-…
charleenfei Apr 9, 2024
05a07d2
followup to lcm testing pr
charleenfei Apr 10, 2024
627153e
linter
charleenfei Apr 10, 2024
115ab27
update: use lcm entrypoint
charleenfei Apr 10, 2024
ec87578
update: use lcm entrypoint
charleenfei Apr 10, 2024
006f59e
linter
charleenfei Apr 10, 2024
9511d11
Merge branch 'main' into charly/followup-lcm-testing
charleenfei Apr 11, 2024
844768b
linter
charleenfei Apr 11, 2024
58fd73f
merge artifact
charleenfei Apr 11, 2024
5282cf8
Merge branch 'main' into charly/followup-lcm-testing
charleenfei Apr 11, 2024
3da3d23
Merge branch 'main' into charly/followup-lcm-testing
damiannolan Apr 15, 2024
e04bdbf
Merge branch 'main' into charly/followup-lcm-testing
charleenfei Apr 15, 2024
1bf0647
add single test for panics cases
crodriguezvega Apr 22, 2024
5a21530
Merge branch 'main' into charly/followup-lcm-testing
crodriguezvega Apr 23, 2024
d8db359
a bit of linting a day keeps the doctor away
crodriguezvega Apr 23, 2024
5108292
more linting
crodriguezvega Apr 23, 2024
e404237
fix test
crodriguezvega Apr 24, 2024
0f229c2
Merge branch 'main' into charly/followup-lcm-testing
crodriguezvega Apr 24, 2024
55a8e08
Merge branch 'main' into charly/followup-lcm-testing
crodriguezvega Apr 24, 2024
ab15a6f
Merge branch 'main' into charly/followup-lcm-testing
charleenfei Apr 30, 2024
24a4927
Merge branch 'main' into charly/followup-lcm-testing
charleenfei May 2, 2024
ac5549a
Merge branch 'main' into charly/followup-lcm-testing
damiannolan May 7, 2024
417ec30
Merge branch 'main' of github.com:cosmos/ibc-go into charly/followup-…
colin-axner May 21, 2024
dedc682
test: fixup testing logic
colin-axner May 21, 2024
fd8ba4e
nit: use errors.New() where no args are present for formatting
damiannolan May 21, 2024
987d581
Merge branch 'main' into charly/followup-lcm-testing
damiannolan May 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/core/02-client/keeper/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,9 @@ func (suite *KeeperTestSuite) TestUpdateClientEventEmission() {
path := ibctesting.NewPath(suite.chainA, suite.chainB)
path.SetupClients()

trustedHeight := path.EndpointA.GetClientState().(*ibctm.ClientState).LatestHeight
tmClientState, ok := path.EndpointA.GetClientState().(*ibctm.ClientState)
suite.Require().True(ok)
trustedHeight := tmClientState.LatestHeight
header, err := path.EndpointA.Counterparty.Chain.IBCClientHeader(path.EndpointA.Counterparty.Chain.LatestCommittedHeader, trustedHeight)
suite.Require().NoError(err)

Expand Down
4 changes: 3 additions & 1 deletion modules/core/02-client/keeper/keeper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,9 @@ func (suite *KeeperTestSuite) TestIBCSoftwareUpgrade() {

path := ibctesting.NewPath(suite.chainA, suite.chainB)
path.SetupClients()
upgradedClientState = path.EndpointA.GetClientState().(*ibctm.ClientState).ZeroCustomFields()
tmClientState, ok := path.EndpointA.GetClientState().(*ibctm.ClientState)
suite.Require().True(ok)
upgradedClientState = tmClientState.ZeroCustomFields()

// use height 1000 to distinguish from old plan
plan = upgradetypes.Plan{
Expand Down
Loading
Loading