imp(transfer): allow unwinding of multiple tokens #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
force-pushed
the
jim/6838-unwind-multiple-tokens
branch
from
873574c
to
d74d188
Compare
10 tasks
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
- Add getUnwindHops helper that iterates over all coins, ensures hop is equal for all and returns the full hops. - Tweak unwind hops to call getUnwindHops, and assign values to hops, source port, source channel. - Remove validation condition that forbids multiple coins when unwind is true.
DimitrisJim
force-pushed
the
jim/6838-unwind-multiple-tokens
branch
from
d9424d0
to
065b452
Compare
DimitrisJim
force-pushed
the
jim/6838-unwind-multiple-tokens
branch
from
ffb7832
to
33cbd72
Compare
…be all unwound together.
DimitrisJim
force-pushed
the
jim/6838-unwind-multiple-tokens
branch
from
33cbd72
to
47f5081
Compare
DimitrisJim
changed the title
colin-axner
reviewed
Jul 17, 2024
colin-axner
reviewed
Jul 17, 2024
colin-axner
approved these changes
Jul 17, 2024
|
crodriguezvega
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Fantastic work, @DimitrisJim! Thank you also for updating the docs.
gjermundgaraba
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Changes look good. I would feel slightly more comfortable if the getUnwindHops was united tested as the logic is important. I imagine we do unit test it elsewhere, but it seems like an easy one to actually unit test :) But happy to have it tested more indirectly also.
Made it into a function so as to not clutter unwindHops, could've inlined it there. Perfectly fine if we want to add tests for both individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6838
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.