feat: add provider info query

[yaruwangway]

Description

Closes: #1110

a manual query in docker:

interchain-security-cd q ccvconsumer provider-info
consumer:
  ChainID: consu
  ChannelID: channel-0
  ClientID: 07-tendermint-0
  ConnectionID: connection-0
provider:
  ChainID: provi
  ChannelID: channel-0
  ClientID: 07-tendermint-0
  ConnectionID: connection-0

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• Included the correct type prefix in the PR title
• Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
• Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
• Targeted the correct branch (see PR Targeting)
• Provided a link to the relevant issue or specification
• Followed the guidelines for building SDK modules
• Included the necessary unit and integration tests
• Added a changelog entry to CHANGELOG.md
• Included comments for documenting Go code
• Updated the relevant documentation or specification
• Reviewed "Files changed" and left comments if necessary
• Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage

[yaruwangway]

According to issue #1110, I only returned providerChainID when query QueryProviderChainInfo in consumer. Or shall i return the whole ClientState info ?
Here is the ClientSteate info:

type ClientState struct {
    ChainId                      string           `protobuf:"bytes,1,opt,name=chain_id,json=chainId,proto3" json:"chain_id,omitempty"`
    TrustLevel                   Fraction         `protobuf:"bytes,2,opt,name=trust_level,json=trustLevel,proto3" json:"trust_level" yaml:"trust_level"`
    TrustingPeriod               time.Duration    `protobuf:"bytes,3,opt,name=trusting_period,json=trustingPeriod,proto3,stdduration" json:"trusting_period" yaml:"trusting_period"`
    UnbondingPeriod              time.Duration    `protobuf:"bytes,4,opt,name=unbonding_period,json=unbondingPeriod,proto3,stdduration" json:"unbonding_period" yaml:"unbonding_period"`
    MaxClockDrift                time.Duration    `protobuf:"bytes,5,opt,name=max_clock_drift,json=maxClockDrift,proto3,stdduration" json:"max_clock_drift" yaml:"max_clock_drift"`
    FrozenHeight                 types.Height     `protobuf:"bytes,6,opt,name=frozen_height,json=frozenHeight,proto3" json:"frozen_height" yaml:"frozen_height"`
    LatestHeight                 types.Height     `protobuf:"bytes,7,opt,name=latest_height,json=latestHeight,proto3" json:"latest_height" yaml:"latest_height"`
    ProofSpecs                   []*ics23.ProofSpec `protobuf:"bytes,8,rep,name=proof_specs,json=proofSpecs,proto3" json:"proof_specs,omitempty" yaml:"proof_specs"`
    UpgradePath                  []string         `protobuf:"bytes,9,rep,name=upgrade_path,json=upgradePath,proto3" json:"upgrade_path,omitempty" yaml:"upgrade_path"`
    AllowUpdateAfterExpiry       bool             `protobuf:"varint,10,opt,name=allow_update_after_expiry,json=allowUpdateAfterExpiry,proto3" json:"allow_update_after_expiry,omitempty" yaml:"allow_update_after_expiry"`
    AllowUpdateAfterMisbehaviour bool             `protobuf:"varint,11,opt,name=allow_update_after_misbehaviour,json=allowUpdateAfterMisbehaviour,proto3" json:"allow_update_after_misbehaviour,omitempty" yaml:"allow_update_after_misbehaviour"`
}

[MSalopek]

According to issue #1110, I only returned providerChainID when query QueryProviderChainInfo in consumer. Or shall i return the whole ClientState info ? Here is the ClientSteate info:

type ClientState struct {
    ChainId                      string           `protobuf:"bytes,1,opt,name=chain_id,json=chainId,proto3" json:"chain_id,omitempty"`
    TrustLevel                   Fraction         `protobuf:"bytes,2,opt,name=trust_level,json=trustLevel,proto3" json:"trust_level" yaml:"trust_level"`
    TrustingPeriod               time.Duration    `protobuf:"bytes,3,opt,name=trusting_period,json=trustingPeriod,proto3,stdduration" json:"trusting_period" yaml:"trusting_period"`
    UnbondingPeriod              time.Duration    `protobuf:"bytes,4,opt,name=unbonding_period,json=unbondingPeriod,proto3,stdduration" json:"unbonding_period" yaml:"unbonding_period"`
    MaxClockDrift                time.Duration    `protobuf:"bytes,5,opt,name=max_clock_drift,json=maxClockDrift,proto3,stdduration" json:"max_clock_drift" yaml:"max_clock_drift"`
    FrozenHeight                 types.Height     `protobuf:"bytes,6,opt,name=frozen_height,json=frozenHeight,proto3" json:"frozen_height" yaml:"frozen_height"`
    LatestHeight                 types.Height     `protobuf:"bytes,7,opt,name=latest_height,json=latestHeight,proto3" json:"latest_height" yaml:"latest_height"`
    ProofSpecs                   []*ics23.ProofSpec `protobuf:"bytes,8,rep,name=proof_specs,json=proofSpecs,proto3" json:"proof_specs,omitempty" yaml:"proof_specs"`
    UpgradePath                  []string         `protobuf:"bytes,9,rep,name=upgrade_path,json=upgradePath,proto3" json:"upgrade_path,omitempty" yaml:"upgrade_path"`
    AllowUpdateAfterExpiry       bool             `protobuf:"varint,10,opt,name=allow_update_after_expiry,json=allowUpdateAfterExpiry,proto3" json:"allow_update_after_expiry,omitempty" yaml:"allow_update_after_expiry"`
    AllowUpdateAfterMisbehaviour bool             `protobuf:"varint,11,opt,name=allow_update_after_misbehaviour,json=allowUpdateAfterMisbehaviour,proto3" json:"allow_update_after_misbehaviour,omitempty" yaml:"allow_update_after_misbehaviour"`
}

Client state is not needed, only ClientId.

The issue states this as a nice to have:

• The connection ends between the provider and consumer, containing the client ids on the provider and consumer side

I think you can get all the info needed using functions from ibc.ChannelKeeper:

• GetChannelConnection
• GetConnection
  • this func will return exported.ConnectionI which has GetClientId() and GetCounterparty() methods you can call

You may need to add those functions to the expected_keepers.go to make them available in ICS

[yaruwangway]

hi @MSalopek , i can get providerClientID, but for the connectionEnd, I need connectionID, how could i know connectionID?

 connectionEnd, found := k.connectionKeeper.GetConnection(ctx, "connectionID")

[MSalopek]

hi @MSalopek , i can get providerClientID, but for the connectionEnd, I need connectionID, how could i know connectionID?

 connectionEnd, found := k.connectionKeeper.GetConnection(ctx, "connectionID")

Answered in a pair programming session.

[p-offtermatt]

Thanks for the nice work!
Changes look good to me. One suggestion, I think in a few places there should be errors returned instead of nil. If you do really want to return nil there, I think you might want to add a comment explaining why.
Other than that, make sure to run make lint locally, seems the CI linter is complaining

[MSalopek]

Pls fix the linter issues

[MSalopek]

LGTM

Not sure the mock is actually used?

[shaspitz]

@yaruwangway please include a PR link next time