Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebuild protos #915

Closed
wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented May 3, 2023

Description

This PR runs make proto-gen, against the main branch, which should not result in changes to the .pb.go files, but did.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol this just changes a comment. Approved

@faddat
Copy link
Contributor Author

faddat commented May 5, 2023

Hey man, I don't know what you think is funny here, anytime the proto files change. They should be rebuilt. It's not a laughing matter. I'll create a CI job to make sure this doesn't happen again.

We found the same issues in comet and a similar matter in Gaia.

@faddat
Copy link
Contributor Author

faddat commented May 5, 2023

This no longer changes any files. Looks like another pr rebuilt protos, like every pr that changes protos should. I have no idea what's funny here.

@faddat faddat closed this May 5, 2023
@shaspitz
Copy link
Contributor

shaspitz commented May 5, 2023

I'll create a CI job to make sure this doesn't happen again.

This would be very useful, I've created an issue here #919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants