Update engine.go #389
Merged
Update engine.go #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the issue on Windows, thanks! 🙌 Tested it also inside WSL and there seems to be no issues there. |
The old version did not print out any log.print or other log outputs under windows (in powershell/cmd/git bash) for us. After that change it worked. It is just a hacky solution currently. Happily awaiting feedback if this is actually a soultion. Thanks
|
the test cases in linux and mac os is passed, but i cannot test in windows bcs I dont have windows device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version did not print out any log.print or other log outputs under windows (in powershell/cmd/git bash) for us. After that change it worked. It is just a hacky solution currently. Happily awaiting feedback if this is actually a soultion.
Thanks
close #412 #430