acra_configui

[mozhmike]

No description provided.

[Lagovas]

?)

[mozhmike]

cleaned

[Lagovas]

can we remove this lines? https://godoc.org/golang.org/x/tools/cmd/goimports - this tool drop unnecessary imports and add missing. it help to not care about commenting some imports. (golang IDE can run it for every .go file on save)

[mozhmike]

cleaned. Tip: IDE can manage this using "Reformat Code" action

[Lagovas]

I thought how we can avoid duplicating and remembered that we can operate with interface{} or map values and convert to/from json/yaml. But when I tried use struct directly I took correct converting without hacks

package main

import (
	"fmt"
	"gopkg.in/yaml.v2"
	"encoding/json"
)

type SomeStruct struct{
	A string
	B bool
	C int
	D []string
}

func main(){
	var a SomeStruct
        // var a map[string]interface{} // it works too
	if err := json.Unmarshal([]byte(`{"A": "str", "B": true, "C": 123, "D": ["a1", "a2", "a3"]}`), &a); err != nil{
		panic(err)
	}
	fmt.Println(a)
	out, err := yaml.Marshal(a)
	if err != nil{
		panic(err)
	}
	fmt.Println(string(out))
}

So I think better to use one struct instead two and avoid problem with synchronization

[mozhmike]

It fails for me in go1.5.4 with struct tags to make input/output more json/yaml convenient and compatible to current configs

[Lagovas]

Where is this struct used?

[mozhmike]

removed

[Lagovas]

I think better to log error and exit. Then we can collect logs and do some processing, count errors, etc.

[mozhmike]

Agree to log, but it's request processing and we should continue with return

[Lagovas]

we can panic and log together. panic to process error as it expected by framework and add log record to process it in a future with our format, not with format of panic messages. Human message like "can't parse post form in 'getConfig' api methid" will be better than something like "incorrect url parameters format"

[mozhmike]

done

[Lagovas]

log.Debugln?

[mozhmike]

done

[Lagovas]

what about to return out as is ([]byte) and convert to string on demand on client's code? many places in golang expects []byte and it leave ability to avoid double convert operation between string and []byte (each operation do full copy of data)

[mozhmike]

agree, done

[Lagovas]

I think config don't need to know anything about http.Request and will be great to operate with []byte on config side and operate with http.Request on http handler side
Plus better to return reference (*ConfigProxy) to config instead copy of value

[mozhmike]

JsonFromPOST is not used any more, removed

[Lagovas]

I was confused when read ConfigProxy in acraserver package because now acraserver shouldn't know about acraproxy and can operate with clients directly. But when read field's name I understood that you mean proxying arcaserver's config to webui config. Maybe better to rename to UIEditableConfig or something more understandable?

[mozhmike]

accepted

[Lagovas]

we can avoid extra struct and convert like

conf := map[string]interface{} {"ProxyHost": config.proxyHost, "ProxyPort": config.proxyPort}
out, err := json.Marshal(conf)

And better to use Getters. Previously I said that no matter how to fetch values. But remembered that I added getter/setter for extra logic when operate with config. For example to log getting/settings, to encapsulate logic of settings if it will be more complex than just assign field

[mozhmike]

using getters