Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dependencies control [T1069] #334

Merged
merged 8 commits into from
Mar 20, 2019
Merged

add dependencies control [T1069] #334

merged 8 commits into from
Mar 20, 2019

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Mar 19, 2019

  • use golang modules as dependency management tool
  • force modules usage in circleci config
  • update dockerfile to build with correct dependencies
  • small refactoring some bash scripts: split with newlines several commands at one line
  • add Gopkg.[lock|toml] files to fix dependencies for go dep which may be used with old golang versions (but not sure that current library versions support old versions of golang ... )

ilammy
ilammy approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Now the dependency versions are finally pinned.

.circleci/prepare.sh Outdated Show resolved Hide resolved
.circleci/prepare.sh Outdated Show resolved Hide resolved
vixentael
vixentael approved these changes Mar 19, 2019
View reviewed changes
Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shadinua
shadinua approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@shadinua shadinua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It happened! :-)

@Lagovas Lagovas merged commit c7b1c88 into cossacklabs:master Mar 20, 2019
@Lagovas Lagovas deleted the lagovas/T1069-add-dependencies-control branch March 18, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilammy ilammy ilammy approved these changes

@vixentael vixentael vixentael approved these changes

@shadinua shadinua shadinua approved these changes

@storojs72 storojs72 storojs72 approved these changes

Assignees
No one assigned
Labels
core docker enhancement go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lagovas @ilammy @vixentael @shadinua @storojs72