Turn off poison detection by default for AS/AT #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add integration tests with poison records and acra-translator remove copy-paste code in tests, re-use same for on/off poison record detection
vixentael
reviewed
Feb 2, 2022
| @@ -482,16 +482,19 @@ func realMain() error { | |||
|
|
|||
| poisonCallbacks := poison.NewCallbackStorage() | |||
| if *detectPoisonRecords { | |||
| log.WithField(logging.FieldKeyEventCode, logging.EventCodePoisonRecordDetectionMessage).Infoln("Turned on poison record detection") | |||
| os.Exit(1) | ||
| log.Errorln("executed code after os.Exit") | ||
| log.WithField(logging.FieldKeyEventCode, logging.EventCodePoisonRecordDetectionMessage).Errorln("executed code after os.Exit") |
There was a problem hiding this comment.
Suggested change
| log.WithField(logging.FieldKeyEventCode, logging.EventCodePoisonRecordDetectionMessage).Errorln("executed code after os.Exit") | |
| log.WithField(logging.FieldKeyEventCode, logging.EventCodePoisonRecordDetectionMessage).Errorln("Executed code after os.Exit") |
should it also start from the capital letter?
There was a problem hiding this comment.
no, this code should not be executed because after os.Exit. It's just honeypot that we check in our integration tests that it's not executed and service stopped.
| # how long wait forked process to respond | ||
| FORK_TIMEOUT = 2 | ||
| # seconds for sleep call after failed polling forked process | ||
| FORK_FAIL_SLEEP = 0.1 |
Co-authored-by: vixentael <vixentael@users.noreply.github.com>
vixentael
approved these changes
Feb 2, 2022
Zhaars
approved these changes
Feb 3, 2022
Lagovas
deleted the
lagovas/T2439-turn-off-poison-detection-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poison_detect_enableflag for acra-[server|translator] product-docs#230Checklist
with new changes