Remove placeholders from connection when done #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name will be reused later.
After the encoding error the Acra crafts and sends `Error` and `ReadyForQuery` packets and starts skipping until database sends `ReadyForQuery`. The latter is also skipped. This means that the Acra doesn't proceeds ReadyForQuery in every execution path. Change it to explicitly proceed `ReadyForQuery` from database, which will trigger cleanup of the state.
Lagovas
approved these changes
May 18, 2022
| # | ||
| # row = await conn.fetchrow(select_query, data['id']) | ||
| # self.assertEqual(data['value_bytes'], row['value_bytes']) | ||
| await conn.execute(insert_query, data['id'], data['value_bytes']) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves interference problem of placeholders. They are saved in the connection, but were never removed, only replaced. That means, they could affect other queries on the same connection.
Solve this, by removing the placeholders at the end of the query: when
ReadyForQueryarrives.I didn't write a new test for this, because 1) it already existed as a part of another test and 2) it's really hard to reproduce.
Checklist
Public API has proper documentation in the Acra documentation site or has PR on documentation repositorywith new changes
CHANGELOG.md is updated (in case of notable or breaking changes)Benchmark results are attached (if applicable)Example projects and code samples are up-to-date (in case of API changes)