Improve progress column output #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the awk magic which should align output columns with some ANSI code magic that aligns status strings in a separate column to the right. This tends to work better with our current file names. Previous code tends to insert ugly newlines for some really long file names.
|
I guess it should be possible to align the columns even more nicely near the right edge of the terminal, but my VT-fu is too weak for that at the moment. Or not... |
Use more magic to determine a proper right edge of the terminal so that we support smaller windows. However, don't move too far right. 80x25 terminal windows are still a thing and should be readable enough.
vixentael
approved these changes
Mar 6, 2019
shadinua
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the awk magic which should align output columns with some ANSI code magic that aligns status strings in a separate column to the right. This tends to work better with our current file names. Previous code tends to insert ugly newlines for some really long file names.
Before:
After:
Note nicely aligned columns and no weird empty lines after long file names.