-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2 support #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bye bye python2
@@ -576,6 +577,10 @@ _Code:_ | |||
Existing master key API (`SCellSeal(key=...)`) should not be used with passphrases or passwords. | |||
Use master key API with symmetric encryption keys, such as generated by `GenerateSymmetricKey()` ([#561](https://github.com/cossacklabs/themis/pull/561)). | |||
Use passphrase API with human-readable passphrases. | |||
- <a id="0.13.0-drop-python-2">Python 2 is no longer supported</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anchors in changelog! Luxury life 😸
We might need to update this workflow also https://github.com/cossacklabs/themis/blob/master/.github/workflows/test-python.yaml#L56 |
Yep, thanks, already saw it. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Python 2 had reached EOL on 2020-01-01.
In fact, we are not making any changes in this release that break compatibility, but we no longer officially support it. This means that we do not run any CI tests for Python 2, and free to develop code compatible only with Python 3+.