Provide default export from the main module #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because WasmThemis 0.13.X has been using CommonJS modules, various
transpilers interepreted
import themis from 'wasm-themis';
as a valid way to import WasmThemis stuff under "themis" namespace
in genuine ES6 code.
The "correct" way to do this is as follows:
import * as themis from 'wasm-themis';
but we need to make sure that the previous form still works.
It's awkward, but when did "it looks awful" was an arguments against
making a breaking change?
"index.ts" exports all Secure Cell variations individually and this file is not really used anywhere else. File structure of WasmThemis is implementation detail. You're not supposed to peek into it.
ilammy
added
the
W-WasmThemis 🌐
Lagovas
approved these changes
Jul 14, 2021
|
|
||
| // And of course export all public things individually. | ||
|
|
||
| export { |
There was a problem hiding this comment.
wat?) I need to go on some nodejs/es6 courses and learn how works new imports in javascript world....
There was a problem hiding this comment.
It's not like I have much clue myself, lol, I'm just reading the MDN:
vixentael
approved these changes
Jul 15, 2021
Comment on lines
-19
to
+22
| export { SecureCellSeal } from "./secure_cell_seal"; | ||
| export { SecureCellTokenProtect } from "./secure_cell_token_protect"; | ||
| export { SecureCellContextImprint } from "./secure_cell_context_imprint"; | ||
| export { ThemisError, ThemisErrorCode } from "./themis_error"; | ||
| export { | ||
| import { SecureCellSeal } from "./secure_cell_seal"; | ||
| import { SecureCellTokenProtect } from "./secure_cell_token_protect"; | ||
| import { SecureCellContextImprint } from "./secure_cell_context_imprint"; | ||
| import { ThemisError, ThemisErrorCode } from "./themis_error"; | ||
| import { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because WasmThemis 0.13.X has been using CommonJS modules, various transpilers interpreted
as a valid way to import WasmThemis stuff under
themisnamespace in genuine ES6 code. (For example, WasmThemis example with webpack is written like that.)The "correct" way to do this is as follows:
but we need to make sure that the previous form still works.
Exporting things twice is awkward, but when did “it looks awful” was a valid argument against making a breaking change?
(While we're here, drop unnecessary
secure_cell.tsfile.index.tsexports all Secure Cell variations individually and this file is not really used anywhere else. File structure of WasmThemis is implementation detail (except forlibthemis.wasmlocation, I guess). You're not supposed to peek into it.)Checklist
Example projects and code samples are up-to-date(they already use this form)Changelog is updated(should not have changed in the first place)