Check Emscripten toolchain version for WasmThemis #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep around the Emscripten SDK that should be used to build WasmThemis. This allows to easily verify that you have the right SDK available.
WasmThemis preparation (Emscripen install) needs access to the repo now. Check out the code before other dependencies are installed.
Instead of hardcoding the expected Emscripten version, use the one maintained in the repository.
Now that we have everything in place, verify that Emscripten environment matches the one we expect. "emsdk" command does not support any sort of "version" query, but the "emcc" binary conveniently includes a version.
Since users might be accustomed to building WasmThemis with whatever version they have available, make it known that from now on you are expected to use exactly the version we support. At least, if you're building WasmThemis via our Makefile.
ilammy
added
infrastructure
vixentael
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we have ran into some issues with building WasmThemis because of Emscripten toolchain mismatch. It seems WasmThemis is pretty heavily dependent on the Emscripten version and might fail to build with anything but the currently supported one. Let's make this official then.
src/wrappers/themis/wasm/emscripten/VERSIONfile now contains the Emscripten SDK version that's supposed to be used to build WasmThemis. CI can fetch it from there to install the right version. I've taught GitHub Actions to do this. @shadinua, please take care of BuildBot 🙏Additionally,
make wasmthemiscommand now verifies that current Emscripten version matches the one in the version file and fails the build if they don't agree. There is no escape hatch. Wanna try a different version – edit the VERSION file.Checklist