Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Emscripten toolchain version for WasmThemis #879

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Check Emscripten toolchain version for WasmThemis #879

merged 5 commits into from
Nov 24, 2021

Commits on Nov 24, 2021

  1. wasm: Introduce emscripten/VERSION 

    Keep around the Emscripten SDK that should be used to build WasmThemis.
This allows to easily verify that you have the right SDK available.
    @ilammy
    ilammy committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    86ae5e3 View commit details
    Browse the repository at this point in the history

  2. CI: Check out Themis before installing non-system dependenices 

    WasmThemis preparation (Emscripen install) needs access to the repo now.
Check out the code before other dependencies are installed.
    @ilammy
    ilammy committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    2df661d View commit details
    Browse the repository at this point in the history

  3. CI: Install Emscripten using the version from the repo 

    Instead of hardcoding the expected Emscripten version, use the one
maintained in the repository.
    @ilammy
    ilammy committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    01818e8 View commit details
    Browse the repository at this point in the history

  4. wasm/Makefile: Verify Emscripten environment version 

    Now that we have everything in place, verify that Emscripten environment
matches the one we expect. "emsdk" command does not support any sort of
"version" query, but the "emcc" binary conveniently includes a version.
    @ilammy
    ilammy committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    9ebfc21 View commit details
    Browse the repository at this point in the history

  5. changelog: Mention "make wasmthemis" behavior change 

    Since users might be accustomed to building WasmThemis with whatever
version they have available, make it known that from now on you are
expected to use exactly the version we support. At least, if you're
building WasmThemis via our Makefile.
    @ilammy
    ilammy committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d40ba18 View commit details
    Browse the repository at this point in the history