Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zero-knowledge proofs to secure comparator for parameter validation #89

Merged
merged 6 commits into from
Jan 4, 2016

Conversation

ignatk
Copy link
Contributor

@ignatk ignatk commented Dec 25, 2015

No description provided.

@ignatk
Copy link
Contributor Author

ignatk commented Dec 25, 2015

This changes the amount of data sent between peers. Ruby and Python tests seem not like it. @mnaza can you, please, take a look?

@mnaza
Copy link
Contributor

mnaza commented Jan 3, 2016

@secumod, IMHO in secure_comparator_alice_step3 to verify signature by

themis_status = ed_dbl_base_verify(5, &(comp_ctx->g2), &(comp_ctx->g3), &(comp_ctx->Pp), &Qb, ((unsigned char *)output) + (8 * ED25519_GE_LENGTH));

must read signature from input not from output.

step4 and step5 have same errors.

@ignatk
Copy link
Contributor Author

ignatk commented Jan 3, 2016

That's weird. How did the tests pass then? Will take a closer look...

@mnaza
Copy link
Contributor

mnaza commented Jan 3, 2016

In test You use shared memory with fixed length. And each time when You use ed_dbl_base_verify real length of buffer by 4*32 less then previous. By this reason signature is on the place every time.

mnaza added a commit that referenced this pull request Jan 4, 2016
Add zero-knowledge proofs to secure comparator for parameter validation
@mnaza mnaza merged commit 6d3c8f2 into cossacklabs:master Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants